[2.1] Camera swiching

[Kohedlo]

After creating camera view and next swiching by this same methos(by adding new workspace) need comeback to old camera wiew. This method not works third time, becaose camera is attached to this window and workspake has been created first time and give unexcepted crash of app. And no exists method for removing old workspace or debuild schemme(with camera deataching).

Code: Select all

 Ogre::CompositorManager2 *compositorManager = Ogre::Root::getSingletonPtr()->getCompositorManager2();

		w = SOMENAME;
        if( !compositorManager->hasWorkspaceDefinition(wp) )
        {
			compositorManager->createBasicWorkspaceDef(wp,backgroundColor, Ogre::IdString() );
		}
		
		compositor_workspace = compositorManager->addWorkspace( sm, rwin, cam, w , true );

[dark_sylinc]

Camera's don't belong to a workspace.

So:

• How to reproduce (provide more code)
• Where is it crashing? Callstack?

[Kohedlo]

Crash occours afer caling addWorkspace( method.

In depth process go throught "workspace = OGRE_NEW CompositorWorkspace(" where throught LogMessaging works fine.

Code: Select all

CompositorWorkspace* CompositorManager2::addWorkspace( SceneManager *sceneManager,
                                             const CompositorChannel &finalRenderTarget,
                                             Camera *defaultCam, IdString definitionName,
                                             bool bEnabled, int position,
                                             const Vector4 &vpOffsetScale,
                                             uint8 vpModifierMask, uint8 executionMask )
    {
		
        validateAllNodes();



        CompositorWorkspace *workspace = 0;

        CompositorWorkspaceDefMap::const_iterator itor = mWorkspaceDefs.find( definitionName );
        if( itor == mWorkspaceDefs.end() )
        {
            OGRE_EXCEPT( Exception::ERR_ITEM_NOT_FOUND, "Workspace definition '" +
                            definitionName.getFriendlyText() + "' not found",
                            "CompositorManager2::addWorkspace" );
        }
        else
        {
			
            workspace = OGRE_NEW CompositorWorkspace(
                                Id::generateNewId<CompositorWorkspace>(), itor->second,
                                finalRenderTarget, sceneManager, defaultCam, mRenderSystem,
                                bEnabled, executionMask, vpModifierMask, vpOffsetScale ); 

--// go to this point fine


            mQueuedWorkspaces.push_back( QueuedWorkspace( workspace, position ) );
        }

		

      


        return workspace;
    }

How to reproduce (provide more code)

- if need, i can record video, create real trandlation for remote desctop or five see code on my cpu or open text files.

[Kohedlo]

Next code have body of "С" key case on wxWidgets. The Key on and off camera preview by using сameraActorPreviewEnabled bollean states.

/* code by Wow-bomb game studios. Only for preview and evaluation/ Non commercial */

Code: Select all

/*  code by Wow-bomb game studios. Only for preview and evaluation/ Non commercial */

if(this->ORTHO == false)
if(m_sm->getName() == CfgManager::getSingleton().main_scene_manager_name)
if(IsMouseInWindow())
if(wxGetKeyState(wxKeyCode('C')) )
if(isCameraActorSelected == true)
{

if(сameraActorPreviewEnabled == false)
{

if(hasCameraID(mRayedObject->getName()))
{

        Ogre::CompositorManager2 *compositorManager = Ogre::Root::getSingletonPtr()->getCompositorManager2();

		wp = mRayedObject->getName();
        if( !compositorManager->hasWorkspaceDefinition(wp) )
        {
			compositorManager->createBasicWorkspaceDef(wp,
				CfgManager::getSingleton().m_current_editor_schemme->backgroundColor
				, Ogre::IdString() );
		}
		
		  //  if(compositor_workspace_p != NULL)
		//	compositorManager->removeWorkspace(compositor_workspace_p);
		
			//compositorManager->removeAllWorkspaces();
            //compositorManager->removeAllWorkspaceDefinitions();
		
		compositor_workspace_p = compositorManager->addWorkspace( m_sm, m_rwin, GetCameraID(mRayedObject->getName()), wp, true ); // mRayedObject->getName() - Cam for prewiew










		


//vpCamera = m_vp->getCamera();

//m_vp->setCamera(Ogre::Root::getSingletonPtr()->getSceneManager(CfgManager::getSingleton().main_scene_manager_name)->findCamera(mRayedObject->getName()));
сameraActorPreviewEnabled = true;
}

}
else
{
	if(m_cam != NULL)
	{



 Ogre::CompositorManager2 *compositorManager = Ogre::Root::getSingletonPtr()->getCompositorManager2();

      
        
		wp = m_cam->getName();
        if( !compositorManager->hasWorkspaceDefinition(wp) )
        {
			compositorManager->createBasicWorkspaceDef(wp,
				CfgManager::getSingleton().m_current_editor_schemme->backgroundColor
				, Ogre::IdString() );
        
		
		
		}
		
			//if(compositor_workspace_p != NULL)
			//compositorManager->removeWorkspace(compositor_workspace_p);
				
		//wxMessageBox(m_cam->getName());
			//compositorManager->removeAllWorkspaces();
            //compositorManager->removeAllWorkspaceDefinitions();
	

			compositor_workspace_p = compositorManager->addWorkspace( m_sm, m_rwin, m_cam, wp, true );  // m_cam - old editor camera for purpose rollingback by camera swich


//m_vp->setCamera(vpCamera);
сameraActorPreviewEnabled = false;
	}
textArea_3->setCaption("\n");
}

}

[c6burns]

/* code by Wow-bomb game studios. Only for preview and evaluation/ Non commercial */

Good thing this clause is there otherwise someone could steal all this super valuable code

[Kohedlo]

we protect from trolls

[Kohedlo]

Crash occours afer caling addWorkspace( method.

The method calls fine. Error occours with next frame update.

[Kohedlo]

some issues: http://www.ogre3d.org/forums/viewtopic.php?f=25&t=83147

[Kohedlo]

all works fine. error on unexisted text panel at :

Code: Select all

textArea_3->setCaption("\n");