Bug in OgreHlmsJson.cpp

Discussion area about developing with Ogre-Next (2.1, 2.2 and beyond)


Post Reply
User avatar
SolarPortal
OGRE Contributor
OGRE Contributor
Posts: 203
Joined: Sat Jul 16, 2011 8:29 pm
Location: UK
x 51
Contact:

Bug in OgreHlmsJson.cpp

Post by SolarPortal »

Hi,

Just noticed a potential mistake in the OgreHlmsJson.cpp at line 160 and 162 inside the "CompareFunction HlmsJson::parseCompareFunction( const char *value )" function.
The Greater and Greater_Equals are flipped.

Code: Select all

        if( !strcmp( value, "greater_equal" ) )
            return CMPF_GREATER;
        if( !strcmp( value, "greater" ) )
            return CMPF_GREATER_EQUAL;
i believe it should be:

Code: Select all

        if( !strcmp( value, "greater_equal" ) )
            return CMPF_GREATER_EQUAL;
        if( !strcmp( value, "greater" ) )
            return CMPF_GREATER;
Lead developer of the Skyline Game Engine: https://aurasoft-skyline.co.uk
User avatar
dark_sylinc
OGRE Team Member
OGRE Team Member
Posts: 5299
Joined: Sat Jul 21, 2007 4:55 pm
Location: Buenos Aires, Argentina
x 1279
Contact:

Re: Bug in OgreHlmsJson.cpp

Post by dark_sylinc »

Fixed. Thanks for the report.
Post Reply