syedhs
17-03-2007 13:46:05
CaseyB,
First of all, thanks for the wonderful library.
I begin integrating your library into my app - migrating from FMOD.
Okay one question which I cant help noticing it.. why is it classes inheriting from Ogre::Singleton need getSingleton() and getSingletonPtr. It is pretty much covered by the Singleton template, so you dont need that. For example:-
The lines above are not needed.
Edit: Right after I posted this posting, I notice that the classes inherit from Singleton privately, so this maybe the reason why. I am sure you have reason for this.. so why?
I am a curious cat 
Secondly, why I didn't you give the option to user to retrieve the sound files using absolute directory (not thru resource manager)? Sometimes, sound file name may be the same but they are not the same. Consider this scenario of when there are 5 vehicles in the games and each of them has engine.wav, brake.wav, skid.wav etc. It is not very clean to actually rename them to be engine_car1.wav, engine_car2.wav etc. It is better to give the user options either to load via Ogre resource manager or direct full path name.
First of all, thanks for the wonderful library.

Okay one question which I cant help noticing it.. why is it classes inheriting from Ogre::Singleton need getSingleton() and getSingletonPtr. It is pretty much covered by the Singleton template, so you dont need that. For example:-
/** Returns the Listener singleton object */
static Listener& getSingleton();
/** Returns a pointer to the Listener singleton object */
static Listener* getSingletonPtr();
The lines above are not needed.
Edit: Right after I posted this posting, I notice that the classes inherit from Singleton privately, so this maybe the reason why. I am sure you have reason for this.. so why?


Secondly, why I didn't you give the option to user to retrieve the sound files using absolute directory (not thru resource manager)? Sometimes, sound file name may be the same but they are not the same. Consider this scenario of when there are 5 vehicles in the games and each of them has engine.wav, brake.wav, skid.wav etc. It is not very clean to actually rename them to be engine_car1.wav, engine_car2.wav etc. It is better to give the user options either to load via Ogre resource manager or direct full path name.