(SVN) some GUIManagerDesc parameters ignored?

christianboutin.com

21-09-2009 20:37:38

I was tweaking with the clickTime parameter and found out it appears to be ignored. At least if you set it as it is below:

GUIManagerDesc d;
d.clickTime = 99999;
mGUIManager = QuickGUI::Root::getSingletonPtr()->createGUIManager(d);


In QuickGUIManager.cpp, shouldn't the constructor looks like this (with the last line "mGUIManagerDesc(d)" added) :
GUIManager::GUIManager(GUIManagerDesc& d) :
mAutoRepeatEnableTimer(NULL),
mAutoRepeatInjectionTimer(NULL),
mDraggingWidget(false),
mActiveSheet(0),
mButtonMask(0),
mKeyDownEvent(false),
mWidgetUnderMouseCursor(0),
mLastClickedWidget(0),
mDownOnBorder(false),
mKeyModifiers(0),
mPreviousBorder(BORDER_NONE),
mResizableBorder(BORDER_NONE),
mViewportWidth(0),
mViewportHeight(0),
mGUIManagerDesc(d)


instead of this:

GUIManager::GUIManager(GUIManagerDesc& d) :
mAutoRepeatEnableTimer(NULL),
mAutoRepeatInjectionTimer(NULL),
mDraggingWidget(false),
mActiveSheet(0),
mButtonMask(0),
mKeyDownEvent(false),
mWidgetUnderMouseCursor(0),
mLastClickedWidget(0),
mDownOnBorder(false),
mKeyModifiers(0),
mPreviousBorder(BORDER_NONE),
mResizableBorder(BORDER_NONE),
mViewportWidth(0),
mViewportHeight(0)


It fixes my issue anyway, but I wonder if it's by design that not all of "d"'s members are copied into mGUIManager.

kungfoomasta

21-09-2009 23:00:11

oops. :oops:

Not only do I not copy over all user provided values, but I don't provided getter/setter functions to set them, as I normally do.

I'll add this in over the next few days, thanks for bringing it up!