Another (design?) Bug: Mouse requires "qgui" skins

Chaster

22-01-2008 05:51:54

Howdy,

I was attempting to make my own skinset, so I started with the "qgui" one from the quickgui demo, and then renamed all the files to start with "pjx" instead of "qgui" (i.e. "pjx.button.png") and then making the requisite changes in my own code during setup of QuickGUI.

However, it turns out that when I create the QuickGUI manager, it creates the mouse using the "qgui" skinset. This isn't changeable because it's hardcoded in there (see line 44 in QuickGUIManager.cpp) Can this be changed to eliminate this hardcoded dependency?

It also seems to be hardcoded in QuickGUIText and QuickGUITree...

Thanks,

Chaster

kungfoomasta

22-01-2008 07:43:55

The Tree is contributed code, I haven't had a chance to review it. I can add in the fix for the GUIManager, it would require an extra parameter in its constructor. (the name of the SkinSet)

I'm not at a point where I can commit, but I will add it to my code base, so it will be in there on my next commit.

Chaster

23-01-2008 16:51:16

The Tree is contributed code, I haven't had a chance to review it. I can add in the fix for the GUIManager, it would require an extra parameter in its constructor. (the name of the SkinSet)

I'm not at a point where I can commit, but I will add it to my code base, so it will be in there on my next commit.


Thanks KungfooMasta, that's fantastic. =)

Chaster

masterfalcon

27-01-2008 03:37:19

Now that the GUIManager constructor takes the default skinset now, qgui is still hardcoded on line 152 in createSheet. Of course, Tree and Text do as well.

kungfoomasta

27-01-2008 19:45:33

Thanks for pointing this out, I have committed fixes for all but the Tree widget. I will work on that at a later date, its not finished.

Chaster

28-01-2008 17:55:59

Thanks!

Chaster